8000 Issue #16960: introduce `UnusedLocalMethodCheck` (RSPEC-S1144) by Pankraz76 · Pull Request #16894 · checkstyle/checkstyle · GitHub
[go: up one dir, main page]

Skip to content

Issue #16960: introduce UnusedLocalMethodCheck (RSPEC-S1144) #16894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Pankraz76
Copy link
@Pankraz76 Pankraz76 commented Apr 18, 2025

Issue #16960: introduce UnusedLocalMethodCheck (RSPEC-S1144)

@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch 2 times, most recently from 3ed5531 to b449654 Compare April 18, 2025 17:52
@@ -66,6 +66,7 @@ unnecessary.paren.string=文字列 {0} の前後に不要な括弧がありま
unnecessary.semicolon=不要なセミコロン。
unused.catch.parameter=未使用のキャッチパラメータ ''{0}'' には名前を付けないでください。
unused.lambda.parameter=未使用のラムダパラメータ ''{0}'' には名前を付けないでください。
unused.local.method=ローカル変数 '' {0} '' が未使用です。
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c&p as i cant edit this. Who to fix this plz?

Copy link
Author 8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrmancuso could you help me out on this one please? its a new feature which we all like and its kind of approved, even if not formally. Its just this little issue, then we can work this out pretty quick.

@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch 2 times, most recently from 37952ad to 9a56486 Compare April 18, 2025 17:54
@Pankraz76 Pankraz76 changed the title Issue #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144) 16894 #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144) Apr 18, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 9a56486 to 12b567d Compare April 18, 2025 17:55
@Pankraz76 Pankraz76 changed the title 16894 #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144) Pull #16894: introduce UnusedLocalMethodCheck (RSPEC-S1144) Apr 18, 2025
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 18, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 12b567d to 9f176f2 Compare April 18, 2025 17:56
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 18, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 9f176f2 to d5cc027 Compare April 18, 2025 18:56
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 18, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from d5cc027 to 9aaecbf Compare April 18, 2025 19:01
@Pankraz76
Copy link
Author

WIP

@Pankraz76 Pankraz76 closed this Apr 19, 2025
@Pankraz76 Pankraz76 reopened this Apr 19, 2025
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 19, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 9aaecbf to 0b3f584 Compare April 19, 2025 18:55
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 19, 2025
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 19, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 9a1a889 to c73810c Compare April 19, 2025 19:03
@Pankraz76
Copy link
Author

after i18n edit we could merge @romani

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 19, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from c73810c to 3584f7f Compare April 19, 2025 19:08
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 20, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 3584f7f to f59ccd1 Compare April 20, 2025 09:57
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 21, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from f59ccd1 to 61b159b Compare April 21, 2025 10:01
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 21, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 61b159b to 67e3ae5 Compare April 21, 2025 17:29
@Pankraz76 Pankraz76 marked this pull request as ready for review April 21, 2025 19:02
@Pankraz76
Copy link
Author

wip

@Pankraz76 Pankraz76 closed this Apr 22, 2025
@Pankraz76 Pankraz76 reopened this Apr 24, 2025
@Pankraz76
Copy link
Author

needed by: spring-projects/spring-framework#34816

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Apr 25, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch 2 times, most recently from e326ca5 to 9405a4a Compare April 27, 2025 10:13
@Pankraz76 Pankraz76 changed the title Pull #16894: introduce UnusedLocalMethodCheck (RSPEC-S1144) Issue #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144) Apr 27, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 9405a4a to b1f08c3 Compare April 27, 2025 10:14
@Pankraz76 Pankraz76 changed the title Issue #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144) Issue #16960: introduce UnusedLocalMethodCheck (RSPEC-S1144) Apr 27, 2025
@Pankraz76
Copy link
Author

8000

@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch 2 times, most recently from e4203f9 to 8ac9763 Compare April 27, 2025 10:50
@Pankraz76
Copy link
Author

wip

@Pankraz76 Pankraz76 closed this Apr 28, 2025
@Pankraz76 Pankraz76 reopened this May 4, 2025
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 8ac9763 to 1b56d5c Compare May 4, 2025 08:13
@Pankraz76 Pankraz76 force-pushed the UnusedPrivateMethodCheck-pr-pr branch from 1b56d5c to 46afa06 Compare May 7, 2025 08:12
@Pankraz76
Copy link
Author
Pankraz76 commented May 7, 2025

need help with i18n here please @romani

@Pankraz76
Copy link
Author
Pankraz76 commented May 9, 2025

items:

List of missing files in pitest profiles: src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalMethodCheck.java

image

@Pankraz76 Pankraz76 closed this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0