10BC0 Errors resulting from the GitHub API calls should now be properly raised by Andarist · Pull Request #820 · changesets/changesets · GitHub
[go: up one dir, main page]
Skip to content

Errors resulting from the GitHub API calls should now be properly raised #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Andarist merged 2 commits into from
May 31, 2022
Merged

Errors resulting from the GitHub API calls should now be properly raised #820

Andarist merged 2 commits into from
May 31, 2022

Conversation

@Andarist
Copy link
Member
@Andarist Andarist commented May 30, 2022

I got a report from @mikearnaldi that data can be returned in a shape like this:

{
  data: { a0: null },
  errors: [
    {
      type: 'NOT_FOUND',
      path: [Array],
      locations: [Array],
      message: "Could not resolve to a Repository with the name 'repo-tooling/eslint-plugin-dprint'."
    }
  ]
}

This is a simple fix to at least make those errors pop up in the CLI logs.

@Andarist Andarist requested a review from emmatown May 30, 2022 13:35
@changeset-bot
Copy link
changeset-bot bot commented May 30, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 71eb176

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@changesets/get-github-info Patch
@changesets/changelog-github Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link
codesandbox-ci bot commented May 30, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71eb176:

Sandbox Source
Vanilla Configuration

emmatown
emmatown reviewed May 31, 2022
View reviewed changes
@Andarist Andarist merged commit a22eb8c into main May 31, 2022
@Andarist Andarist deleted the fix/github-api-graphql-errors branch May 31, 2022 06:39
@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatown emmatown emmatown approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Andarist @emmatown
0