10000 Fix `TestMeshgrid` by toslunar · Pull Request #8420 · chainer/chainer · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestMeshgrid #8420

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix TestMeshgrid #8420

merged 1 commit into from
Nov 13, 2019

Conversation

toslunar
Copy link
Member

@toslunar
Fix TestMeshgrid
717b359 
Make the input values and the output shape smaller to fix the flakiness of the test.
Avoid builtin `random` because `numpy.random` is available.
@toslunar toslunar added cat:test Test or CI related. to-be-backported Pull request that should be backported. labels Nov 12, 2019
@emcastillo
Copy link
Member

This PR reduces the error probability or deoes it gets rid of it :)?

@toslunar
Copy link
Member Author

Passed

  • 1000 loops for each test and
  • 20000 loops for each float16 test.

See also #8285 (comment)

@emcastillo
Copy link
Member

Thats awesome!
Thanks a lot!!

@niboshi
Copy link
Member
niboshi commented Nov 13, 2019

Jenkins, test this please

@niboshi niboshi mentioned this pull request Nov 13, 2019
Closed
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 717b359, target branch master) failed with status FAILURE.

@niboshi niboshi mentioned this pull request Nov 13, 2019
Closed
@niboshi niboshi added this to the v7.0.0 milestone Nov 13, 2019
@niboshi
Copy link
Member
niboshi commented Nov 13, 2019

Test failure is unrelated.

@niboshi niboshi merged commit 2234ad7 into chainer:master Nov 13, 2019
@niboshi niboshi removed the to-be-backported Pull request that should be backported. label Nov 13, 2019
@niboshi
Copy link
Member
niboshi commented Nov 13, 2019

meshgrid has not been backported (#6668)

@toslunar toslunar deleted the test-meshgrid branch November 13, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:test Test or CI related.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

Flaky test: tests/chainerx_tests/unit_tests/routines_tests/test_creation.py::test_Meshgrid
4 participants
@toslunar @emcastillo @niboshi @chainer-ci
0