8000 [chainerx] Adds `log10` by ishanrai05 · Pull Request #7015 · chainer/chainer · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chainerx] Adds log10 #7015

Merged
merged 8 commits into from
Apr 23, 2019
Merged

[chainerx] Adds log10 #7015

merged 8 commits into from
Apr 23, 2019

Conversation

ishanrai05
Copy link
Contributor

Solves part of issue #6423

asi1024
asi1024 requested changes Apr 22, 2019
View reviewed changes
@asi1024
Copy link
Member
asi1024 commented Apr 23, 2019

Could you resolve conflicts?

asi1024
asi1024 requested changes 8000 Apr 23, 2019
View reviewed changes
@asi1024 asi1024 added cat:feature Implementation that introduces new interfaces. ChainerX Related to ChainerX. labels Apr 23, 2019
@asi1024 asi1024 added this to the v7.0.0a1 milestone Apr 23, 2019
@asi1024
Copy link
Member
asi1024 commented Apr 23, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 500f172 (8adc309):

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 500f172, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member
asi1024 commented Apr 23, 2019

Jenkins failure seems unrelated to this PR. LGTM!

@asi1024 asi1024 merged commit be33465 into chainer:master Apr 23, 2019
@ishanrai05 ishanrai05 deleted the chx-2 branch April 23, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asi1024 asi1024 asi1024 approved these changes

Assignees

@asi1024 asi1024

Labels
cat:feature Implementation that introduces new interfaces. ChainerX Related to ChainerX.
Projects
None yet
Milestone
v7.0.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@ishanrai05 @asi1024 @pfn-ci-bot @chainer-ci
0