8000 Simplify `F.scatter_add` test by hikjik · Pull Request #7012 · chainer/chainer · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify F.scatter_add test #7012

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Simplify F.scatter_add test #7012

merged 1 commit into from
Apr 26, 2019

Conversation

hikjik
Copy link
@hikjik hikjik commented Apr 21, 2019

Simplifies test_scatter_add using testing.FunctionTestCase
Refer to #6071

@Crissman Crissman self-assigned this Apr 22, 2019
@Crissman
Copy link
Member

LTGM. Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 072a699 (d4856f7):

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 072a699, target branch master) failed with status FAILURE.

@Crissman
Copy link
Member

pfnCI, please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 072a699 (f4af954):

@Crissman
Copy link
Member

pfnCI, please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 072a699 (9db4590):

@Crissman
Copy link
Member

Jenkins failure looks unrelated.

@Crissman Crissman merged commit 8fcb15a into chainer:master Apr 26, 2019
@hikjik hikjik deleted the simplify-scatter-add-test branch April 28, 2019 17:39
@niboshi niboshi mentioned this pull request May 14, 2019
Closed
@Crissman Crissman modified the milestones: v6.0.0, v7.0.0a1 May 14, 2019
@Crissman Crissman added the cat:test Test or CI related. label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Crissman Crissman

Labels
cat:test Test or CI related.
Projects
None yet
Milestone
v7.0.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@hikjik @Crissman @pfn-ci-bot @chainer-ci
0