8000 Fix test parameters in ChainerX math tests by niboshi · Pull Request #6946 · chainer/chainer · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test parameters in ChainerX math tests #6946

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Fix test parameters in ChainerX math tests #6946

merged 1 commit into from
Apr 17, 2019

Conversation

niboshi
Copy link
Member
@niboshi niboshi commented Apr 16, 2019 •
edited
Loading

Skips backward/double-backward tests for inputs that results in non-finite outputs.

Differentiable domains are different among inverse trigonometric functions.

@niboshi niboshi added cat:test Test or CI related. ChainerX Related to ChainerX. labels Apr 16, 2019
@niboshi niboshi mentioned this pull request Apr 16, 2019
Closed
@niboshi niboshi added the pr-blocker Blocking other PRs. label Apr 16, 2019
@niboshi
Copy link
Member Author
niboshi commented Apr 16, 2019

This PR blocks #6947.

@asi1024 asi1024 self-assigned this Apr 16, 2019
@asi1024
Copy link
Member
asi1024 commented Apr 17, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 354d165 (cf17c93):

@imos
Copy link
Member
imos commented Apr 17, 2019

pfnCI, please test
(PFN CI failed because master is updated just after the previous request.)

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 354d165 (30e3349):

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 354d165, target branch master) succeeded!

@asi1024
Copy link
Member B4BE
asi1024 commented Apr 17, 2019

LGTM.

@asi1024 asi1024 merged commit 8fc8e08 into chainer:master Apr 17, 2019
@asi1024 asi1024 added this to the v7.0.0a1 milestone Apr 17, 2019
@asi1024 asi1024 removed the pr-blocker Blocking other PRs. label Apr 17, 2019
@niboshi niboshi deleted the math-test branch April 17, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvy hvy hvy left review comments

@asi1024 asi1024 asi1024 approved these changes

Assignees

@asi1024 asi1024

Labels
cat:test Test or CI related. ChainerX Related to ChainerX.
Projects
None yet
Milestone
v7.0.0a1
Development

Successfully merging this pull request may close these issues.
6 participants
@niboshi @asi1024 @pfn-ci-bot @imos @chainer-ci @hvy
0