[chainerx]Implementation of Absolute #6715
Conversation
| @@ -770,6 +770,17 @@ Array Cos(const Array& x) { | |||
| return out; | |||
| } | |||
|
|
|||
| Array Absolute(const Array& x) { | |||
| Dtype dtype = GetMathResultDtype(x.dtype()); | |||
| Array out = Empty(x.shape(), dtype, x.device()); | |||
There was a problem hiding this comment.
You're allocating an array here which is discarded when being assigned the sum of x_flip_1 and x_flip_2.
|
Thanks for the PR as always. I added some minor comments. Could you take a look? |
| @@ -1630,7 +1630,7 @@ def func(self, xp, a): | |||
| # Special shapes | |||
| chainer.testing.product({ | |||
| 'shape': [(), (0,), (1,), (2, 0, 3), (1, 1, 1), (2, 3)], | |||
| 'in_dtypes,out_dtype': _in_out_dtypes_math_functions, | |||
| 'in_dtypes,out_dtype': _in_out_float_dtypes_math_functions, | |||
There was a problem hiding this comment.
Can you revert this change? It seems unrelated to your PR.
|
Can you write a Python test that checks that |
|
yes, I will do this. |
|
I have added the assertion test. But, I was not able to reproduce the python test errors (dtype mismatch) locally. |
|
I will check it again. |
|
@hvy, I have fixed all the errors. Could you have a look? |
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 8b0efb1, target branch master) failed with status FAILURE. |
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 8b0efb1, target branch master) failed with status FAILURE. |
|
The failure seems to be in TestMaxPool |
|
Indeed, the failures seem unrelated although there were a couple of them except max pool. Thanks for the long running PR, LGTM! |
ref issue: #6423