Support orthogonal embedding initialization #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beam2d Could you take a look at this one as well? |
1 task
muupan
added a commit
to muupan/chainerrl
that referenced
this pull request
May 1, 2019
beam2d
reviewed
May 9, 2019
| if (in_dim > out_dim and self._checks[0]) or ( | ||
| in_dim < out_dim and self._checks[1]): | ||
| raise ValueError( | ||
| 'Cannot make orthogonal {}.' |
There was a problem hiding this comment.
Note: "auto" is not used here, so the message does not corrupt.
|
Jenkins, test this please. |
|
Successfully created a job for commit c5e6c18: |
1 similar comment
|
Successfully created a job for commit c5e6c18: |
|
Jenkins CI test (for commit c5e6c18, target branch master) failed with status FAILURE. |
|
LGTM. Jenkins failure is irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5485.
Merge #5615 first.