8000 fix: Handle case of Azure returning auth error by eplightning · Pull Request #7177 · cert-manager/cert-manager · GitHub
[go: up one dir, main page]
Skip to content

fix: Handle case of Azure returning auth error #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: Handle case of Azure returning auth error #7177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2731e
fix: Handle case of Azure returning auth error
eplightning Jul 15, 2024
30d4fce
Add test case
eplightning Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/issuer/acme/dns/azuredns/azuredns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ func (c *DNSProvider) updateTXTRecord(ctx context.Context, fqdn string, updater
resp, err := c.recordClient.Get(ctx, c.resourceGroupName, zone, name, dns.RecordTypeTXT, nil)
if err != nil {
var respErr *azcore.ResponseError
if errors.As(err, &respErr); respErr.StatusCode == http.StatusNotFound {
if errors.As(err, &respErr); respErr != nil && respErr.StatusCode == http.StatusNotFound {
set = &dns.RecordSet{
Properties: &dns.RecordSetProperties{
TTL: to.Ptr(int64(60)),
Expand Down
11 changes: 11 additions & 0 deletions pkg/issuer/acme/dns/azuredns/azuredns_test.go
8B84
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,17 @@ func TestInvalidAzureDns(t *testing.T) {
assert.Error(t, err)
}

func TestAuthenticationError(t *testing.T) {
provider, err := NewDNSProviderCredentials("", "invalid-client-id", "invalid-client-secret", "subid", "tenid", "rg", "example.com", util.RecursiveNameservers, false, &v1.AzureManagedIdentity{})
assert.NoError(t, err)

err = provider.Present(context.TODO(), "example.com", "_acme-challenge.example.com.", "123d==")
assert.Error(t, err)

err = provider.CleanUp(context.TODO(), "example.com", "_acme-challenge.example.com.", "123d==")
assert.Error(t, err)
}

func populateFederatedToken(t *testing.T, filename string, content string) {
t.Helper()

Expand Down
0