8000 Check that url_rule is not None before dereferencing property by jtbeach · Pull Request #781 · census-instrumentation/opencensus-python · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Check that url_rule is not None before dereferencing property#781

Merged
reyang merged 1 commit intocensus-instrumentation:masterfrom
jtbeach:task/fix-rule-error
Sep 3, 2019
Merged

Check that url_rule is not None before dereferencing property#781
reyang merged 1 commit intocensus-instrumentation:masterfrom
jtbeach:task/fix-rule-error

Conversation

@jtbeach
Copy link
Contributor
@jtbeach jtbeach commented Sep 2, 2019 •
edited
Loading

Fixes #777

@jtbeach jtbeach requested review from a team, c24t, reyang and songy23 as code owners September 2, 2019 01:12
@googlebot
Copy link
googlebot commented Sep 2, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jtbeach
Copy link
Contributor Author
jtbeach commented Sep 2, 2019

@googlebot I signed it!

@googlebot
Copy link
googlebot commented Sep 2, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 2, 2019
@jtbeach jtbeach mentioned this pull request Sep 2, 2019
Closed
@olance
Copy link
Contributor
olance commented Sep 2, 2019

@jtbeach you should improve the tests I had provided for the HTTP_ROUTE attribute, to add one that specifically tests a non-existing route.

Happy to help if needed!

@jtbeach jtbeach force-pushed the task/fix-rule-error branch from e97831a to fdb4bd1 Compare September 3, 2019 00:33
@jtbeach jtbeach force-pushed the task/fix-rule-error branch from 07f0eba to cc7a43e Compare September 3, 2019 01:46
@jtbeach
Copy link
Contributor Author
jtbeach commented Sep 3, 2019

@olance @reyang I think this is now ready for review

reyang
reyang approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor
@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyang reyang merged commit 2457a87 into census-instrumentation:master Sep 3, 2019
@reyang
Copy link
Contributor
reyang commented Sep 3, 2019

Thanks @jtbeach and @olance!

@jtbeach
Copy link
Contributor Author
jtbeach commented Sep 25, 2019

@reyang Any idea when a release will be made with this fix?

This was referenced Oct 1, 2019
Merged
Merged
@lzchen
Copy link
Contributor
lzchen commented Oct 1, 2019

@jtbeach
https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.7.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@c24t c24t Awaiting requested review from c24t

@songy23 songy23 Awaiting requested review from songy23

1 more reviewer

@reyang reyang reyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flask middleware raises AttributeError for 404 routes

5 participants

@jtbeach @googlebot @olance @reyang @lzchen
0