Add runtime in success signal #9516
Conversation
| @@ -528,7 +528,7 @@ def trace_task(uuid, args, kwargs, request=None): | |||
| if task_on_success: | |||
| task_on_success(retval, uuid, args, kwargs) | |||
| if success_receivers: | |||
| send_success(sender=task, result=retval) | |||
| send_success(sender=task, result=retval, runtime=T) | |||
There was a problem hiding this comment.
can you add a test case to verify this change?
There was a problem hiding this comment.
Sorry if the test isn't perfect, I did my best to fit it in with everything else :D.
There was a problem hiding this comment.
Hello, may I resolve this change request, or are further changes required?
There was a problem hiding this comment.
it seems good. but since we are on the middle of a new stable release, so thinking if we should add or hold this for a while
There was a problem hiding this comment.
Yeah, completely understand, no problem!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9516 +/- ##
=======================================
Coverage 78.51% 78.51%
=======================================
Files 153 153
Lines 19127 19127
Branches 2533 2533
=======================================
Hits 15018 15018
Misses 3821 3821
Partials 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
50a34a7 to
4deb84c
Compare
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Send the task runtime to the success signal so users can access this information.
Linked to this issue