8000 Copy `code.co_qualname` on Python >= 3.11 by cjwatson · Pull Request #423 · celery/billiard · GitHub
[go: up one dir, main page]
Skip to content

Copy code.co_qualname on Python >= 3.11 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Copy code.co_qualname on Python >= 3.11 #423

merged 1 commit into from
Apr 7, 2025

Conversation

cjwatson
Copy link
Contributor
@cjwatson cjwatson commented Apr 7, 2025

As of the changes to linecache in
python/cpython#117174, logging tracebacks requires code objects to have a co_qualname attribute, which is true for native Python code objects as of 3.11. Adjust billiard's emulation of them to match.

Spotted by pagure's tests in https://bugs.debian.org/1101621; analysis and patch by Rebecca N. Palmer rebecca_palmer@zoho.com.

@cjwatson
Copy code.co_qualname on Python >= 3.11
070be17 
As of the changes to `linecache` in
python/cpython#117174, logging tracebacks
requires code objects to have a `co_qualname` attribute, which is true
for native Python code objects as of 3.11.  Adjust billiard's emulation
of them to match.

Spotted by pagure's tests in https://bugs.debian.org/1101621; analysis
and patch by Rebecca N. Palmer <rebecca_palmer@zoho.com>.
@Nusnus Nusnus self-requested a review April 7, 2025 10:34
Nusnus
Nusnus approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member
@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nusnus Nusnus merged commit d8b2df5 into celery:main Apr 7, 2025
7 of 8 checks passed
@cjwatson cjwatson deleted the co-qualname branch April 8, 2025 08:43
@ericbuehl
Copy link

any plans for a new release? i'm seeing errors of missing co_qualname pop up in python 3.13.3+ and this fixes it for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nusnus Nusnus Nusnus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjwatson @ericbuehl @Nusnus
0