8000 Core - Update CefErrorCodes by campersau · Pull Request #3785 · cefsharp/CefSharp · GitHub
[go: up one dir, main page]
Skip to content

Core - Update CefErrorCodes#3785

Merged
amaitland merged 1 commit intocefsharp:masterfrom
campersau:errorcodes
Sep 3, 2021
Merged

Core - Update CefErrorCodes#3785
amaitland merged 1 commit intocefsharp:masterfrom
campersau:errorcodes

Conversation

@campersau
Copy link
Contributor
@campersau campersau commented Sep 1, 2021

Related: #3784

Summary:

Changes:

var text = document.documentElement.textContent,
    result = [],
    comment = [];

text.split("\n").forEach(line => {
    if (!line) {
        if (comment.length > 0) {
            result.push("", ...comment);
            comment = [];
        }
    }
    else if (line.startsWith("//")) {
        comment.push(line);
    }
    else if (line.startsWith("NET_ERROR")) {
        result.push(
            "",
            "/// <summary>",
            ...comment.map(c => "/" + c),
            "/// </summary>",
            line.replace(/NET_ERROR\((.*?), (.*?)\)/, (match, name, code) => name.split("_").map(n => n[0] + n.substring(1).toLowerCase()).join("") + " = " + code + ",")
        );
        comment = [];
    }
});

copy(result.join("\n"))
  • Manually update Icann to ICANN

There are some breaking changes, most notably the rename from Spdy to Http2.

I also compared it to the 93 branch and it looks like there are no changes there.

How Has This Been Tested?
Build works.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@AppVeyorBot
Copy link
AppVeyorBot commented Sep 1, 2021

✅ Build CefSharp 92.0.250-CI4194 completed (commit 9cb7b67597 by @campersau)

@amaitland amaitland added this to the 93.1.x milestone Sep 3, 2021
@amaitland amaitland merged commit 1cdb219 into cefsharp:master Sep 3, 2021
@campersau campersau deleted the errorcodes branch September 3, 2021 04:55
@campersau campersau mentioned this pull request Sep 21, 2021
Merged
9 tasks
@campersau campersau mentioned this pull request Jan 15, 2022
Merged
9 tasks
@campersau campersau mentioned this pull request Jun 25, 2024
Merged
9 tasks
@campersau campersau mentioned this pull request May 12, 2025
Merged
9 tasks
@campersau campersau mentioned this pull request Dec 16, 2025
Merged
9 tasks
@campersau campersau mentioned this pull request Jan 31, 2026
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

93.1.x

Development

Successfully merging this pull request may close these issues.

3 participants

@campersau @AppVeyorBot @amaitland
0