E524 Improved comparison API in core module by dekuenstle · Pull Request #60 · cblearn/cblearn · GitHub
[go: up one dir, main page]
Skip to content

Improved comparison API in core module #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dekuenstle wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

Improved comparison API in core module #60

dekuenstle wants to merge 48 commits into from

Conversation

@dekuenstle
Copy link
Collaborator
@dekuenstle dekuenstle commented Mar 24, 2023

No description provided.

dekuenstle added 30 commits March 23, 2023 23:51
@dekuenstle
Add refactored datatype utils
ff4326f
@dekuenstle
Update settings, document changes
b20807f
@dekuenstle
Fix bugs in core comparison validation
fd09984
@dekuenstle
Use core validation inside utils validation
11d800b
@dekuenstle
Embeddings use classifier-like sklearn API
5489a5b
@dekuenstle
Drop python 3.9 support: Improved typing
19b3762
@dekuenstle
Fix material dataset: Unroll responses with new API
8bfc7c2
@dekuenstle
Editor configs
b77f5ff
@dekuenstle
Fix bug: comparisons were mutual
278a929
@dekuenstle
comparison hc test compatible with ne api
83ee839
@dekuenstle
Estimator test compatible with new api
4269925
@dekuenstle
Whitespace
20a45b3
@dekuenstle
Update install instructions
89460d0
@dekuenstle
Avoid sampling undecided triplets
70c2a19
@dekuenstle
Fix typo
e7ddcc5
@dekuenstle
Fix sampling
f2d20b0
@dekuenstle
Rename robin->pairwise
04affef
@dekuenstle
Rename file
e399130
@dekuenstle
Deprecate old check_query API
6b9efe2
@dekuenstle
Fix: Poor seed for test
5938941
@dekuenstle
Implement MVTE (Multi-View Triplet Embedding)
fe5ab7e
@dekuenstle
Expose MVTE in docs and lib
b5d48fe
@dekuenstle
Handle sample weight tests
34f9c2e
@dekuenstle
Add procrustes alignment
4024434
@dekuenstle
Fix sampling
b23fd5b
@dekuenstle
use scipy-like dendrogram in ComparisonHC
19c92f1
@dekuenstle
New example: clustering of car dataset
0e974ce
@dekuenstle
Fix procrustes alignment: whiten of the correct axis
8a9284f
@dekuenstle
Fix docstring in example
a6942d8
@dekuenstle
Rename car example to "plot" keyword
aac837c
@codecov
Copy link
codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.47414% with 21 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (7d1bd10) to head (34f9c2e).
Report is 22 commits behind head on main.

❗ Current head 34f9c2e differs from pull request most recent head eed32e1

Please upload reports for the commit eed32e1 to get more accurate results.

Files Patch % Lines
cblearn/embedding/_base.py 87.80% 5 Missing ⚠️
cblearn/core/check_comparison.py 96.49% 4 Missing ⚠️
cblearn/core/generate_comparison.py 78.94% 4 Missing ⚠️
cblearn/core/type_comparison.py 94.82% 3 Missing ⚠️
cblearn/datasets/_triplet_indices.py 77.77% 2 Missing ⚠️
cblearn/datasets/_triplet_response.py 92.85% 1 Missing ⚠️
cblearn/embedding/_ste.py 99.02% 1 Missing ⚠️
cblearn/utils/_validate_data.py 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   92.31%   92.68%   +0.36%     
==========================================
  Files          40       44       +4     
  Lines        1614     1764     +150     
==========================================
+ Hits         1490     1635     +145     
- Misses        124      129       +5
Flag Coverage Δ
unittests 92.68% <95.47%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dekuenstle
0