8000 Cay89/patch 1 by codetetic · Pull Request #1 · cay89/symfony · GitHub
[go: up one dir, main page]
Skip to content

Cay89/patch 1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2023
Merged

Cay89/patch 1 #1

merged 2 commits into from
Apr 3, 2023

Conversation

codetetic
Copy link

I noticed your symfony/symfony PR request was stuck due to a missing unit test.

This pull request adds that test.

cay89 and others added 2 commits January 5, 2023 13:43
@cay89
Update Table.php
b7ed1c1 
Use mb_str_split instead of str_split because it's work wrong with multibyte chars when there is automatic width adjustment.
@codetetic
Add test for multibyte character column width.
aafc8a2
@cay89 cay89 merged commit b6dfdaf into cay89:6.3 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codetetic @cay89
0