[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set num_epochs = 1 as default in State #756

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

pdanilov
Copy link
Contributor

Description

Default num_epochs values in State class was equal to maximal integer value, so it leads to behaviour when inference stage has no provided num_epochs value in config, and we've got infinitely long repeated cycle. Now it defaults to 1 to avoid these cases.

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the Code of Conduct document.
  • I have read the Contributing guide.
  • I have checked the code style using catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • I have written tests for all new methods and classes that I created.
  • I have written the docstring in Google format for all the methods and classes that I used.
  • I have checked the docs using make check-docs.
  • I have read I need to click 'Login as guest' to see Teamcity build logs.

@Scitator Scitator merged commit d0265ca into catalyst-team:master Apr 15, 2020
pdanilov added a commit to pdanilov/catalyst that referenced this pull request Aug 2, 2020
* Set num_epochs = 1 as default in State

* Get rid of redundant import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants