-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pre commit hook #1257
Merged
Merged
Adding Pre commit hook #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditwoo
previously approved these changes
Jul 12, 2021
ditwoo
previously approved these changes
Jul 13, 2021
Updated hooks to pull codestyle from official repository (current pr in master). Probably a good idea to switch to release tag once it will be released (or shall we release it as a patch now?) |
|
Scitator
previously approved these changes
Jul 15, 2021
ditwoo
previously approved these changes
Jul 15, 2021
mergify
bot
dismissed stale reviews from ditwoo and Scitator
July 15, 2021 17:01
Pull request has been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for THIS PR to go first.
Looking forward to confirmation/approval to go over the checklist
Adds pre-commit setup for code style auto-check on any commit. Right now (Draft) linked to my fork of
codestyle
for testing purposes, once PR is merged, will link to the actualcodestyle
repository.How to check / test
pre-commit
:pip install pre-commit
. we'll have to addpre-commit
to dev requirementspre-commit install
( installis git hook script into./git/hooks/pre-commit
)catalyst-make-codestyle
automatically and stop without commit if it has job to do (or at least if it fails, but forblack
it halts if black does any reformating at all).Pros
.git/hooks/pre-commit
file, so all developers get it by default, they don't need to read documentation, installcodestyle
, etc, etc.codestyle
in the repo.Cons
Side Notes
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?latest
andminimal
requirements?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: