-
Notifications
You must be signed in to change notification settings - Fork 221
Tests: Verify some basic SDO record and array assumptions #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adjust the EDS test accordingly, since the record length only counts sub-objects that have an actual description.
Switch from CompactSubObj to actual sub-entries. Leave out some of the sub-entries, targeting specific SDO tests.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 71.00% 71.16% +0.16%
==========================================
Files 26 26
Lines 3114 3114
Branches 527 527
==========================================
+ Hits 2211 2216 +5
+ Misses 771 766 -5
Partials 132 132 |
|
Notice how 5cbb00e still passes the tests. |
edited
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
As requested in #538, this will show where the current
SdoRecordlength / iteration behavior is inconsistent. Some other tests related toSdoArraylength and iteration added as well, for symmetry.