8000 Change type() into isinstance() by sveinse · Pull Request #357 · canopen-python/canopen · GitHub
[go: up one dir, main page]
Skip to content

Change type() into isinstance() #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christiansandberg merged 1 commit into from
Apr 3, 2023
Merged

Change type() into isinstance() #357

christiansandberg merged 1 commit into from
Apr 3, 2023

Conversation

@sveinse
Copy link
Collaborator
@sveinse sveinse commented Mar 25, 2023

It is generally preferred to use isinstance() over type() for checking the type of objects. This PR makes some minor cleanups on the use of type().

@christiansandberg christiansandberg merged commit 5efd421 into canopen-python:master Apr 3, 2023
@sveinse sveinse deleted the feature-fix-typechecks branch April 5, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christiansandberg christiansandberg christiansandberg approved these changes

@acolomb acolomb acolomb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sveinse @christiansandberg @acolomb
0