8000 edited multipath text for clarity (tech writer) by thornshadow99 · Pull Request #155 · canonical/ubuntu-server-documentation · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@thornshadow99
Copy link
Contributor

Description

Per Open Documentation Academy #162, edited text for clarity

Related Issue

If this pull request addresses an existing issue, please link to it below. Use the Fixes #<issue-number> syntax to
close the issue automatically when the pull request is merged.

Example:

  • Fixes: #1234

Contributor License Agreement (CLA)

By contributing to this project, you agree to the terms of
the Canonical Contributor License Agreement (CLA).
If you have not already signed the CLA, please do so here.


Commit Message for Squash Merge

We typically squash commits when merging. You can specify the commit message that should be used in this case if you wish.
Provide the desired commit message below:

[(optional) category] Brief description of changes made, and why


Checklist


Additional Notes (Optional)

Add any extra information or context that reviewers may need to know. This could include testing instructions,
screenshots, or links to related discussions.


Thank you for contributing to the Ubuntu Server documentation!

@bryceharrington
Copy link
Contributor

Text changes LGTM but not sure on procedure for acceptance/landing so am leaving that to Sally.

Copy link
Collaborator
@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your improvements to this page, @thornshadow99. I really love the re-organisation you did, I think it makes a lot of sense and gives the whole page a much more logical flow. Overall this is a really great change.

I did spot a couple of nits, and you'll need to take a look at the table because it's not rendering correctly in the preview (I think I spotted why, I left comments inline).

change suggested by @s-makin

Co-authored-by: Sally <sally.makin@canonical.com>
@thornshadow99 thornshadow99 marked this pull request as draft March 3, 2025 17:47
Made changes as requested by @s-makin (one reversion and a change to a table).
Copy link
Contributor Author
@thornshadow99 thornshadow99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to @s-makin requests for changes--one revision and a modification to the header.

@thornshadow99 thornshadow99 marked this pull request as ready for review March 3, 2025 17:55
Copy link
Collaborator
@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thornshadow99 for making the requested changes, the table is now rendering correctly in the preview and all looks great :) thanks for your work on this page, it's much better organised now and flows way more cleanly

@s-makin s-makin merged commit 7b90980 into canonical:main Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0