-
Notifications
You must be signed in to change notification settings - Fork 95
edited multipath text for clarity (tech writer) #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edited multipath text for clarity (tech writer) #155
Conversation
|
Text changes LGTM but not sure on procedure for acceptance/landing so am leaving that to Sally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your improvements to this page, @thornshadow99. I really love the re-organisation you did, I think it makes a lot of sense and gives the whole page a much more logical flow. Overall this is a really great change.
I did spot a couple of nits, and you'll need to take a look at the table because it's not rendering correctly in the preview (I think I spotted why, I left comments inline).
change suggested by @s-makin Co-authored-by: Sally <sally.makin@canonical.com>
Made changes as requested by @s-makin (one reversion and a change to a table).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded to @s-makin requests for changes--one revision and a modification to the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thornshadow99 for making the requested changes, the table is now rendering correctly in the preview and all looks great :) thanks for your work on this page, it's much better organised now and flows way more cleanly
Description
Per Open Documentation Academy #162, edited text for clarity
Related Issue
If this pull request addresses an existing issue, please link to it below. Use the
Fixes #<issue-number>syntax toclose the issue automatically when the pull request is merged.
Example:
Contributor License Agreement (CLA)
By contributing to this project, you agree to the terms of
the Canonical Contributor License Agreement (CLA).
If you have not already signed the CLA, please do so here.
Commit Message for Squash Merge
We typically squash commits when merging. You can specify the commit message that should be used in this case if you wish.
Provide the desired commit message below:
[(optional) category] Brief description of changes made, and why
Checklist
Additional Notes (Optional)
Add any extra information or context that reviewers may need to know. This could include testing instructions,
screenshots, or links to related discussions.
Thank you for contributing to the Ubuntu Server documentation!