8000 Edited text for clarity by thornshadow99 · Pull Request #146 · canonical/ubuntu-server-documentation · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@thornshadow99
Copy link
Contributor

Description

Per Open Documentation Academy request issue #162, edited the text of this document for clarity.


Related Issue


Contributor License Agreement (CLA)

By contributing to this project, you agree to the terms of
the Canonical Contributor License Agreement (CLA).
If you have not already signed the CLA, please do so here.


Commit Message for Squash Merge

Per Open Documentation Academy request issue #162, edited the text of this document for clarity.


Checklist


Additional Notes (Optional)

Add any extra information or context that reviewers may need to know. This could include testing instructions,
screenshots, or links to related discussions.


Thank you for contributing to the Ubuntu Server documentation!

Copy link
Collaborator
@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thornshadow99 for the very detailed and comprehensive review of this page! Overall I really like the changes you proposed, I think they do add a lot of clarity and your restructuring makes a lot of sense - actually I'd love to go even further with that, and have made one or two suggestions of other things we could move around (see below).

I also spotted a few opportunities for further consolidation - let me know what you think!

@thornshadow99
Copy link
Contributor Author

@s-makin So how do I go back and make changes? Do I select the "convert to draft" command? And how do I revert changes? (Pardon if this applies to the other pull request as well).

@s-makin
Copy link
Collaborator
s-makin commented Feb 25, 2025

@s-makin So how do I go back and make changes? Do I select the "convert to draft" command? And how do I revert changes? (Pardon if this applies to the other pull request as well).

Hi @thornshadow99, I can't seem to see the changes you made, but your branch says it's got commits. If you take a look at your branch, is there an option for you to sync? (should be somewhere near the "code" button)

8000
one more change needed to be made. sorry.
@thornshadow99
Copy link
Contributor Author

ready for review.

Additional changes needed to be made per @s-makin. I missed a few. :)
Copy link
Contributor Author
@thornshadow99 thornshadow99 left a comment
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made. Ready for review by @s-makin.

@thornshadow99
Copy link
Contributor Author

Sorry, didn't mean to close the pull request.

Copy link
Collaborator
@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixups

Copy link
Collaborator
@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thornshadow99 for your patience and hard work on this one! I've taken the liberty of fixing up a couple of nits I spotted in the rendered version of the docs. All looks good to me!

@s-makin s-makin merged commit 09c9a7f into canonical:main Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0