8000 chore: migrate /apps/categories pages by hbjORbj · Pull Request #18871 · calcom/cal.com · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate /apps/categories pages #18871

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Conversation

hbjORbj
Copy link
Contributor
@hbjORbj hbjORbj commented Jan 24, 2025

What does this PR do?

  • Migrate /apps/categories and /apps/categories/[category] to App Router

Tested

Screenshot 2025-01-25 at 12 44 42 PM Screenshot 2025-01-25 at 12 45 03 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Test /apps/categories and /apps/categories/[category]

@graphite-app graphite-app bot requested a review from a team January 24, 2025 15:41
Copy link
vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 5:00pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 5:00pm

@hbjORbj hbjORbj marked this pull request as draft January 24, 2025 15:41
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Jan 24, 2025
@hbjORbj hbjORbj changed the title chore: migrate apps categories pages chore: migrate /apps/categories pages Jan 24, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 24, 2025
Copy link
graphite-app bot commented Jan 24, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor
github-actions bot commented Jan 24, 2025

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review January 24, 2025 21:23
@hbjORbj hbjORbj enabled auto-merge (squash) January 25, 2025 17:45
@hbjORbj hbjORbj merged commit 0dab3e1 into main Jan 25, 2025
40 of 61 checks passed
@hbjORbj hbjORbj deleted the chore/migrate-apps-categories-pages branch January 25, 2025 17:46
ThyMinimalDev pushed a commit that referenced this pull request Jan 27, 2025
* migrate apps/categories pages

* remove pages dir
ThyMinimalDev added a commit that referenced this pull request Jan 27, 2025
* init router endpoint for v2

* fixup fixup

* resolve merge conflicts

* update libraries

* update router controller

* make router endpoint public

* chore: refactor router endpoint and add team/org id

* cleanup

* chore: Only import Sentry when needed (#18882)

* perf: prerender routes in main navigation (#18883)

* chore: migrate /apps/categories pages (#18871)

* migrate apps/categories pages

* remove pages dir

* chore: app router - /payment pages (#18152)

* remove Head from payment page comp

* remove route from pages router

* move out of future folder

* add to config.matcher

* remove unneeded code

* update middleware

* fix

* fix

* perf: replace `getServerSessionForAppDir` usages with our original `getServerSession` function (#18897)

* chore: migrate /apps/installation pages (#18870)

* migrate apps/installation pages

* fix test

* chore: migrate `/auth/logout` (#18901)

* migrate /auth/verify-email page

* update middleware

* migrate /auth/logout page

* expose router endpoint

* small refactor pageprops not necessary

* sentry is already tracking performance

* reuse logic

* fixup! reuse logic

* fixup! fixup! reuse logic

* fixup! fixup! fixup! reuse logic

---------

Co-authored-by: Morgan Vernay <morgan@cal.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
Co-authored-by: Benny Joo <sldisek783@gmail.com>
Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0