8000 fix: Load plain dynamically by zomars · Pull Request #18571 · calcom/cal.com · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Load plain dynamically #18571

Merged
merged 3 commits into from
Jan 22, 2025
Merged

fix: Load plain dynamically #18571

merged 3 commits into from
Jan 22, 2025

Conversation

zomars
Copy link
Member
@zomars zomars commented Jan 9, 2025 •
edited
Loading

What does this PR do?

Prevents warnings on environments where Plain is not setup.

This pull request includes several changes to update the environment variable PLAIN_CHAT_ID to NEXT_PUBLIC_PLAIN_CHAT_ID and to dynamically import the PlainChat component. The most important changes include modifications to environment variables, API route handling, and component imports.

Environment variable updates:

  • .env.example: Changed PLAIN_CHAT_ID to NEXT_PUBLIC_PLAIN_CHAT_ID.
  • turbo.json: Updated the environment variable from PLAIN_CHAT_ID to NEXT_PUBLIC_PLAIN_CHAT_ID.

API route handling:

Component imports:

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team January 9, 2025 23:29
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Jan 9, 2025
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 9, 2025
@graphite-app Graphite App
Copy link
graphite-app bot commented Jan 9, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/09/25)

1 reviewer was added to this PR based on Keith Williams's automation.

zomars
zomars commented Jan 9, 2025
View reviewed changes
.env.example Show resolved Hide resolved
@zomars
Copy link
Member Author
zomars commented Jan 9, 2025

Already matched NEXT_PUBLIC_PLAIN_CHAT_ID to our current PLAIN_CHAT_ID in production.

@zomars zomars enabled auto-merge (squash) January 9, 2025 23:39
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 9, 2025 •
edited
Loading

E2E results are ready!

@vercel Vercel
Copy link
vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 4:47pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 4:47pm

@zomars zomars merged commit 0f07ab2 into main Jan 22, 2025
41 checks passed
@zomars zomars deleted the fix/load-plain-dynamically branch January 22, 2025 20:10
zomars added a commit that referenced this pull request Jan 24, 2025
@zomars
fix: Load plain dynamically (#18571)
d0ac5b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@hbjORbj hbjORbj hbjORbj approved these changes

@nizzyabi nizzyabi Awaiting requested review from nizzyabi

@alishaz-polymath alishaz-polymath Awaiting requested review from alishaz-polymath

Assignees
No one assigned
Labels
core area: core, team members only ❗️ .env changes contains changes to env variables foundation ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zomars @PeerRich @hbjORbj @keithwillcode
0