chore: app router - /getting-started page #18185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/14/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (12/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
hbjORbj
commented
Dec 18, 2024
| @@ -147,11 +146,6 @@ const OnboardingPage = (props: PageProps) => { | |||
| )} | |||
| data-testid="onboarding" | |||
| key={pathname}> | |||
| <Head> | |||
There was a problem hiding this comment.
Head should be removed in app router. It's replaced by generateMetadata in app router route.
eunjae-lee
approved these changes
Dec 18, 2024
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
* remove env vars * move pages to /app * remove Head component * remove pages router * add to config matcher * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test (email-signup onboarding flow)
Screen.Recording.2024-12-17.at.11.58.25.PM.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?