[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add ability to disable Sentry source maps #17699

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

keithwillcode
Copy link
Contributor
@keithwillcode keithwillcode commented Nov 17, 2024

What does this PR do?

Unfortunately as we saw with #11928, we are not able to add any more app router routes to the app without suffering OOM issues while building on Vercel. To try and avoid this blocking issue, we are going to provide a mechanism to not upload source maps

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link
Contributor
github-actions bot commented Nov 17, 2024

E2E results are ready!

@@ -221,8 +221,10 @@ const nextConfig = {
images: {
unoptimized: true,
},
productionBrowserSourceMaps: false,
Copy link
Contributor
@emrysal emrysal Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
productionBrowserSourceMaps: false,
productionBrowserSourceMaps: process.env.SENTRY_DISABLE_CLIENT_SOURCE_MAPS === "0",

Copy link
vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:54pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:54pm

Copy link
graphite-app bot commented Nov 22, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (11/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor
@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this configurability

@keithwillcode keithwillcode changed the title chore: Remove Sentry source maps chore: Add ability to disable Sentry source maps Nov 22, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) November 22, 2024 15:18
@keithwillcode keithwillcode merged commit cd24067 into main Nov 22, 2024
38 checks passed
@keithwillcode keithwillcode deleted the chore/no-sentry-source-maps branch November 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ❗️ .env changes contains changes to env variables foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants