chore: Remove Pages Router / Use App Router - /workflows
#16519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/06/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (09/06/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
|
DO NOT MERGE UNTIL EITHER (1) REVALIDATION LOGIC FOR SSR IS ADDED or (2) SSR IS REVERTED |
|
This PR is being marked as stale due to inactivity. |
<
8000
batch-deferred-content class="d-inline-block" data-url="/commits/badges">
…deploy
/workflows/workflows
hbjORbj
commented
Dec 10, 2024
Comment on lines
+21
to
+31
| // const filters = getTeamsFiltersFromQuery({ ...searchParams, ...params }); | ||
|
|
||
| // let filteredList; | ||
| // try { | ||
| // filteredList = await WorkflowRepository.getFilteredList({ | ||
| // userId: user?.id, | ||
| // input: { | ||
| // filters, | ||
| // }, | ||
| // }); | ||
| // } catch (err) {} |
There was a problem hiding this comment.
commenting out sever-side fetching for now for defensive migration
hbjORbj
commented
Dec 10, 2024
Comment on lines
+40
to
+54
| // const workflow = await WorkflowRepository.getById({ id: +parsed.data.workflow }); | ||
| // let verifiedEmails, verifiedNumbers; | ||
| // try { | ||
| // verifiedEmails = await WorkflowRepository.getVerifiedEmails({ | ||
| // userEmail: user?.email ?? null, | ||
| // userId: user?.id ?? null, | ||
| // teamId: workflow?.team?.id, | ||
| // }); | ||
| // } catch (err) {} | ||
| // try { | ||
| // verifiedNumbers = await WorkflowRepository.getVerifiedNumbers({ | ||
| // userId: user?.id ?? null, | ||
| // teamId: workflow?.team?.id, | ||
| // }); | ||
| // } catch (err) {} |
There was a problem hiding this comment.
commenting out sever-side fetching for now for defensive migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/workflowsroutes from Pages Router and render them from App router.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/workflows/and/workflows/[workflow]