8000 [5.next] Macroable Trait by arshidkv12 · Pull Request #18889 · cakephp/cakephp · GitHub
[go: up one dir, main page]
Skip to content

[5.next] Macroable Trait #18889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 5.next
Choose a base branch
from
Open

[5.next] Macroable Trait #18889

wants to merge 2 commits into from

Conversation

arshidkv12
Copy link
Contributor

@dereuromark dereuromark changed the base branch from 5.x to 5.next September 6, 2025 07:40
dereuromark
dereuromark reviewed Sep 6, 2025
View reviewed changes
src/Utility/MacroableInstanceTrait.php Outdated

if (!is_callable($macro)) {
throw new BadMethodCallException(sprintf(
'Macro for method %s is not callable.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Macro for method %s is not callable.',
'Macro for method `%s()` is not callable.',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@arshidkv12 arshidkv12 force-pushed the macroable5_next branch 2 times, most recently from afa00cb to 611ab71 Compare September 6, 2025 10:56
markstory
markstory reviewed Sep 9, 2025
View reviewed changes
tests/TestCase/Utility/MacroableStaticTraitTest.php
{
return 'privateStaticValue';
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also call clearMacros() here as it looks like we may leak global state in tests here.

src/Utility/MacroableInstanceTrait.php
use BadMethodCallException;
use Closure;

trait MacroableInstanceTrait
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have test coverage on this trait as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstory markstory markstory left review comments

@dereuromark dereuromark dereuromark left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arshidkv12 @markstory @dereuromark
0