6.x string template #18846
6.x string template #18846
Conversation
|
Hi, Regarding the I’m sharing the code (excluding tests, but I can share it) and an example because I think it’s easier to understand what it does and it’s much more visual. // The method name should obviously be changed
public function cx(...$args): string
{
$output = [];
$this->cxRecursive($output, $args);
return trim(implode(' ', array_unique($output)));
}
private function cxRecursive(array &$output, array $args): void
{
foreach ($args as $key => $value) {
if (is_array($value)) {
$this->cxRecursive($output, $value);
} elseif (is_numeric($key) && is_string($value)) {
$output[] = $value;
} elseif ($value === true && is_string($key)) {
$output[] = $key;
}
}
}
# Example
$this->Html->tag('div', 'mycontent', ['class' => $this->Html->cx('foo', ['my-class' => true, 'is-active' => $aBooleanVar]));
// <div class="foo my-class">mycontent</div>
# Usage in the addClassToArray method
public function addClassToArray(
array $attributes,
array|string $newClasses,
string $key = 'class',
): array {
return Hash::insert($attributes, $key, $this->cx($attributes[$key] ?? null, $newClasses));
}I just wanted to share it in case you find it interesting or useful. Otherwise, feel free to disregard this, and thank you for your work. |
If we're considering new APIs for manipulating class names, I would prefer an API closer to |
|
Do you want to make an alternative PR? This one is just resolving the arg and return types for now. |
Part of https://github.com/cakephp/cakephp/wiki/6.0-Ideas TODOs
What do you think? Is this a general improvement in the API?
The codebase now uses the cleaner, more type-safe methods:
We could add this to 5.next as well, but since this is more internal, not sure if we need to.