6.x: Normalize options from snake_case to camelCase #18810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am all for this 👍 |
|
Any other comments? |
|
How do we make these changes easier for upgrading. Right now the 'old' keys will silently fail, and several of these keys are for security related features. We shouldn't silently break behavior in these places, and we'll need an upgrade path that at the very least lets developers know that they need to update their code. |
|
We could keep old ones in place with either warning/error or exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing first point of https://github.com/cakephp/cakephp/wiki/6.0-Ideas
Question:
What is the scope of this? Do we adjust all of them across the framework for consistency? As now showcased here?
Or do we only apply this to a subset?
We can always have fallbacks in place if we want to make certain upgrade paths easier as well.