8000 feat: improve task management, completed task will not re-start again by magicdawn · Pull Request #181 · buxuku/SmartSub · GitHub
[go: up one dir, main page]
Skip to content

feat: improve task management, completed task will not re-start again #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: improve task management, completed task will not re-start again #181

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24a9ca1
feat: improve task management, completed task will not re-start again
magicdawn May 7, 2025
b3edf12
chore: replace class with plain object getters
magicdawn May 7, 2025
6642669
chore: re-use destructing
magicdawn May 7, 2025
11b3e49
chore: merge main & resolve conflicts
magicdawn May 17, 2025
a295806
chore: clean up to reduce diff
magicdawn May 17, 2025
32564fa
chore: replace ITaskFile with IFiles
magicdawn May 17, 2025
5c11155
chore: revert main process code, do not persist formData inside IFiles
magicdawn May 17, 2025
945a80c
chore: remove handleTask options
magicdawn May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: remove handleTask options
  • Loading branch information
@magicdawn
magicdawn committed May 17, 2025
commit 945a80c6bd25a2f21456da4ea3a2eb96aa31f674
20 changes: 9 additions & 11 deletions renderer/components/TaskControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const TaskControls: FC<{
};
}, []);

const handleTask = async (options?: { silentNoNewTask?: boolean }) => {
const handleTask = async () => {
if (!files?.length) {
return toast(t('common:notification'), { description: t('home:noTask') });
}
Expand All @@ -62,12 +62,9 @@ const TaskControls: FC<{

const newTaskFiles = getNewTaskFiles(updatedFiles);
if (!newTaskFiles.length) {
if (!options?.silentNoNewTask) {
toast(t('common:notification'), {
description: t('home:allFilesProcessed'),
});
}
return;
return toast(t('common:notification'), {
description: t('home:allFilesProcessed'),
});
}

// if(formData.model && needsCoreML(formData.model)){
Expand Down Expand Up @@ -108,16 +105,17 @@ const TaskControls: FC<{
if (
taskStatus === 'running' &&
autoStartNewTaskWhenRunning &&
files.length
files.length &&
files.some((f) => !f.sent)
) {
handleTask({ silentNoNewTask: true });
handleTask();
}
}, [files.length]);

return (
<div className="flex gap-2 ml-auto">
{(taskStatus === 'idle' || taskStatus === 'completed') && (
<Button onClick={() => handleTask()} disabled={!files.length}>
<Button onClick={handleTask} disabled={!files.length}>
{t('home:startTask')}
</Button>
)}
Expand Down Expand Up @@ -147,7 +145,7 @@ const TaskControls: FC<{
</>
)}
{taskStatus === 'cancelled' && (
<Button onClick={() => handleTask()} disabled={!files.length}>
<Button onClick={handleTask} disabled={!files.length}>
{t('home:restartTask')}
</Button>
)}
Expand Down
0