8000 Add client config options by griffinmyers · Pull Request #3 · button/button-client-ruby · GitHub
[go: up one dir, main page]
Skip to content

Add client config options #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
griffinmyers merged 2 commits into from
Dec 1, 2016
Merged

Add client config options #3

griffinmyers merged 2 commits into from
Dec 1, 2016

Conversation

@griffinmyers
Copy link
Contributor
@griffinmyers griffinmyers commented Nov 30, 2016

Description

Adding support for a config hash which may be supplied as an optional 2nd argument to the Button::Client#new. This adds support for configurable hostname, port, timeout, and protocol. This should be entirely backwards compatible.

danielmcgrath
danielmcgrath approved these changes Dec 1, 2016
View reviewed changes
Copy link
@danielmcgrath danielmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

lib/button/version.rb Outdated
@@ -1,3 +1,3 @@
module Button
VERSION = '1.0.0'.freeze
VERSION = '1.0.1'.freeze
Copy link
@danielmcgrath danielmcgrath Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.0 for new functionality

@griffinmyers
Copy link
Contributor Author
griffinmyers commented Dec 1, 2016

thanks @danielmcgrath !

@griffinmyers griffinmyers merged commit 9c41e84 into master Dec 1, 2016
@griffinmyers griffinmyers deleted the will/config branch December 1, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danielmcgrath danielmcgrath danielmcgrath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielmcgrath danielmcgrath

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@griffinmyers @danielmcgrath
0