E522 Update quote linting by griffinmyers · Pull Request #37 · button/button-client-python · GitHub
[go: up one dir, main page]
Skip to content

Update quote linting #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
griffinmyers merged 4 commits into from
Sep 20, 2019
Merged

Update quote linting #37

griffinmyers merged 4 commits into from
Sep 20, 2019

Conversation

@griffinmyers
Copy link
Contributor
@griffinmyers griffinmyers commented Sep 13, 2019

Reviewer: @jiaqi216

I locally noticed some flake8 errors related to quoting style. I believe this only manifested locally and not on CI because I have a local flake8 plugin called flake8-quotes installed as an artifact of my environment. In any event, it seemed like a nice lint rule to enforce. Accordingly, this PR:

  1. Includes the plugin in the test environment
  2. Fixes up violations

@griffinmyers griffinmyers self-assigned this Sep 13, 2019
itsJiaqi
itsJiaqi approved these changes Sep 19, 2019
View reviewed changes
Copy link
@itsJiaqi itsJiaqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@griffinmyers griffinmyers merged commit 8d5bdfd into master Sep 20, 2019
@griffinmyers griffinmyers deleted the will/flake branch September 20, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@itsJiaqi itsJiaqi itsJiaqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@griffinmyers griffinmyers

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@griffinmyers @itsJiaqi
0