Add HTTPResponseError to expose underlying http error codes and causes. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffinmyers
approved these changes
May 18, 2018
Contributor
There was a problem hiding this comment.
Thanks much for submitting, @mikeybtn!
This looks good to me. I think we can release this under a minor version--because HTTPResponseError inherits from ButtonClientError, this should be entirely backwards compatible afaict.
Happy to cut a release--let me know.
Contributor
Author
|
Awesome! I tacked on 38cfbef with the version bump. Would you mind doing the honors, merge and publish at your leisure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to distinguish different upstream API errors.