8000 feat: add project groups by jstarry · Pull Request #62 · bufferoverflow/verdaccio-gitlab · GitHub
[go: up one dir, main page]
Skip to content

feat: add project groups #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged 8000

feat: add project groups #62

merged 1 commit into from
Dec 4, 2018

Conversation

jstarry
Copy link
Contributor
@jstarry jstarry commented Dec 3, 2018 •
edited
Loading

References: #63

If a Gitlab user is a maintainer of a project but not a maintainer of the group that the project is in, they should still have publish rights.

@jstarry
Copy link
Contributor Author
jstarry commented Dec 4, 2018

@dlouzan would you mind looking over this PR? Thanks 👍

bufferoverflow
bufferoverflow approved these changes Dec 4, 2018
View reviewed changes
Copy link
Owner
@bufferoverflow bufferoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jstarry this makes sense!

@jstarry
Copy link
Contributor Author
jstarry commented Dec 4, 2018

Cool! Thank you @bufferoverflow for creating this plugin, it's just what we needed 👍

@bufferoverflow
Copy link
Owner

@dlouzan Could you review this as well and merge if you agree on it?

@dlouzan
Copy link
Collaborator
dlouzan commented Dec 4, 2018 •
edited
8000 Loading

This is a great PR, I'm currently checking the code but it really looks fantastic

@dlouzan dlouzan self-assigned this Dec 4, 2018
@dlouzan
Copy link
Collaborator
dlouzan commented Dec 4, 2018

This makes perfect sense. The use of two Gitlab API calls should be completely ok under high load by using the cache.

Your code is actually much more elegant and I love how you used Promise.all and the spread operator to join the results.

LGTM 👍

@dlouzan dlouzan merged commit da9aba8 into bufferoverflow:master Dec 4, 2018
@dlouzan dlouzan mentioned this pull request Dec 4, 2018
Closed
@jstarry jstarry deleted the project-groups branch December 4, 2018 23:19
@dlouzan dlouzan mentioned this pull request May 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferoverflow bufferoverflow bufferoverflow approved these changes

Assignees

@dlouzan dlouzan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstarry @bufferoverflow @dlouzan
0