Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read the learn-rxjs documentation on forkJoin, then read the main documentation at:
https://rxjs.dev/api/index/function/forkJoin
which states:
"""
If any given observable errors at some point, forkJoin will error as well and immediately unsubscribe from the other observables.
"""
I felt that the learn-rxjs documentation did not properly reflect that statement. After reading the learn-rxjs documentation I was under the impression all the inner observables would have completed successfully, including any side effects (i.e. server side state change) they may have caused. But that's not true.
This PR is my suggestion on how to improve the learn-rxjs documentation to properly reflect what the main documentation states.
I also fixed a couple example links that were in the same area.