8000 drm/i915: vlv: fix save/restore of GFX_MAX_REQ_COUNT reg · bsd-unix/linux@b5f1c97 · GitHub
[go: up one dir, main page]

Skip to content

Commit b5f1c97

Browse files
ideakjnikula
authored andcommitted
drm/i915: vlv: fix save/restore of GFX_MAX_REQ_COUNT reg
Due this typo we don't save/restore the GFX_MAX_REQ_COUNT register across suspend/resume, so fix this. This was introduced in commit ddeea5b Author: Imre Deak <imre.deak@intel.com> Date: Mon May 5 15:19:56 2014 +0300 drm/i915: vlv: add runtime PM support I noticed this only by reading the code. To my knowledge it shouldn't cause any real problems at the moment, since the power well backing this register remains on across a runtime s/r. This may change once system-wide s0ix functionality is enabled in the kernel. v2: - resend after a missing git add -u :/ Cc: stable@vger.kernel.org Signed-off-by: Imre Deak <imre.deak@intel.com> Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent 53292cd commit b5f1c97

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/i915/i915_drv.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1038,7 +1038,7 @@ static void vlv_save_gunit_s0ix_state(struct drm_i915_private *dev_priv)
10381038
s->lra_limits[i] = I915_READ(GEN7_LRA_LIMITS_BASE + i * 4);
10391039

10401040
s->media_max_req_count = I915_READ(GEN7_MEDIA_MAX_REQ_COUNT);
1041-
s->gfx_max_req_count = I915_READ(GEN7_MEDIA_MAX_REQ_COUNT);
1041+
s->gfx_max_req_count = I915_READ(GEN7_GFX_MAX_REQ_COUNT);
10421042

10431043
s->render_hwsp = I915_READ(RENDER_HWS_PGA_GEN7);
10441044
s->ecochk = I915_READ(GAM_ECOCHK);
@@ -1119,7 +1119,7 @@ static void vlv_restore_gunit_s0ix_state(struct drm_i915_private *dev_priv)
11191119
I915_WRITE(GEN7_LRA_LIMITS_BASE + i * 4, s->lra_limits[i]);
11201120

11211121
I915_WRITE(GEN7_MEDIA_MAX_REQ_COUNT, s->media_max_req_count);
1122-
I915_WRITE(GEN7_MEDIA_MAX_REQ_COUNT, s->gfx_max_req_count);
1122+
I915_WRITE(GEN7_GFX_MAX_REQ_COUNT, s->gfx_max_req_count);
11231123

11241124
I915_WRITE(RENDER_HWS_PGA_GEN7, s->render_hwsp);
11251125
I915_WRITE(GAM_ECOCHK, s->ecochk);

0 commit comments

Comments
 (0)
0