8000 Sanitizing #180 by pulkitsharma07 · Pull Request #193 · browserstack/browserstack-runner · GitHub
[go: up one dir, main page]
Skip to content

Sanitizing #180 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2017
Merged

Sanitizing #180 #193

merged 3 commits into from
Dec 7, 2017
+50 −7

Conversation

pulkitsharma07
Copy link
Contributor

eugenet8k and others added 3 commits July 24, 2017 11:59
@eugenet8k
Add tunnel_pid and test_server_port settings
064f0e9 
* Add support of `config.tunnel_pid` and cli `—pid` param
  - It should be a string like “/dir1/dir2/file.pid” to save process id
  - It will allow external process to control the tunnel process
  - If automated jobs for browserstack hanged or shutdown, we want to kill previous tunnel process manually before starting tests again.
* Add support of `config.test_server_port` param
  - If not set, the default 8888 port is used
  - List of support ports: https://www.browserstack.com/question/664
@pulkitsharma07
Merging master
3088545
@pulkitsharma07
Adding --pid to README.md
9495f60 
* Renaming config.tunnel_pid to config.tunnel_pid_file
* Regex match for --pid instead of -pid
* Error message on invalid flag
@pulkitsharma07 pulkitsharma07 merged commit c941e04 into master Dec 7, 2017
@pulkitsharma07 pulkitsharma07 deleted the lookout-add-pid-cli-param branch December 7, 2017 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjawa mjawa mjawa approved these changes

@vedharish vedharish vedharish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pulkitsharma07 @mjawa @vedharish @eugenet8k
0