Fix: Add label detection for UI frameworks like Ant Design (#3742) #3758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owser-use#3742) - Labels WITH 'for' attribute are excluded early (they activate their associated input element, causing interference) - Labels WITHOUT 'for' that wrap form controls (input/select/textarea) are detected as interactive (common UI framework pattern) - Checks up to 2 levels deep for nested inputs (Ant Design uses span>input) - Cursor:pointer fallback still works for other label cases This properly supports Ant Design, Element UI, Material UI, and similar frameworks that use labels as wrapper components.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary - Labels WITH
forattribute are excluded (they activate their associated input, causing interference)forthat wrap form controls (input/select/textarea) are detected as interactivespan > input)Closes 3742
Summary by cubic
Fix detection of clickable labels in UI frameworks like Ant Design to prevent mis-clicks and enable proper interaction. Addresses Linear #3742.
Written for commit da6d58f. Summary will update automatically on new commits.