8000 Feature: Add fifo middleware by hadeli · Pull Request #64 · brefphp/symfony-messenger · GitHub
[go: up one dir, main page]

Skip to content

Feature: Add fifo middleware #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hadeli
Copy link
Contributor
@hadeli hadeli commented Aug 16, 2022

In order to facilite fifo attributes usage, i need to automate MessageGroupId & MessageDeduplicationId stamp adding

@mnapoli
Copy link
Member
mnapoli commented Aug 30, 2022

That sounds like a lot of new things to add, document and maintain. Could you clarify why we may want this? "In order to facilite fifo attributes usage" is not that clear to me.

@mnapoli mnapoli added the enhancement New feature or request label Aug 30, 2022
@shouze
Copy link
Contributor
shouze commented Sep 2, 2022

@mnapoli Looks like it makes using SQS message groups plug & play. At the moment Symfony/Messenger just provides the Stamp but no Middleware and probably won't.

As you know, message groups provides the ability of highly concurrent processing messages like when you don't have FIFO queues, but with FIFO queues hence you don't have to bother with message order, the good part of FIFO with the good part of non FIFO.

@mnapoli
Copy link
Member
mnapoli commented Sep 7, 2022

Thanks!

Sorry I'll do a bit of meta, but my intrinsic motivation (to be transparent) is that I don't want to maintain anything more than necessary :p

The goal of this package is to make Symfony Messenger work out of the box on AWS Lambda. I'm wondering if new middlewares/stamps belong specifically in this package, or would instead better be in:

  • either Symfony Messenger itself,
  • or a 3rd party package (if Symfony doesn't want this)

?

I understand the convenience of having this here (works out of the box), but is that feature strictly related to Bref? Or could these classes be useful outside of Bref/AWS lambda?

@tyx
Copy link
Contributor
tyx commented Oct 6, 2022

Hello @mnapoli ,

You're right this stuff is only a help to use AmazonSqsFifoStamp that belongs to Symfony sqs transport.

We will give a try to move this PR overthere

@tyx
Copy link
Contributor
tyx commented Nov 3, 2022

Just create PR on symfony repository : symfony/symfony#48095

We can close here

@hadeli hadeli closed this Nov 3, 2022
@mnapoli
Copy link
Member
mnapoli commented Nov 4, 2022

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0