Add switch to cli to allow choice between Chrome/Firefox#38
Merged
breenmachine merged 6 commits intobreenmachine:masterfrom Jan 27, 2022
Merged
Add switch to cli to allow choice between Chrome/Firefox#38breenmachine merged 6 commits intobreenmachine:masterfrom
breenmachine merged 6 commits intobreenmachine:masterfrom
Conversation
Contributor
Author
|
@breenmachine @jstnkndy I propose adding a switch to the tool to allow a choice of browsers. I use Firefox headless so I was surprised when I pulled master and got Currently I don't bake Chrome webdriver into the docker image, and while I am not opposed, I made this commit to keep the original functionality while extending the improvements that Justin made. |
Changing dockerfile comment pointing to https://hub.docker.com/r/andmyhacks/httpscreenshot as it's 5 years out of date
typo
-p headless flag as an option for both Default is Firefox as the previous changes defaulting to Chrome breaks previous functionality
2980b47 to
cba2861
Compare
Owner
|
Hey Jesse, thanks so much for the PR. I agree it's nice to have both options. Merging it now. |
Contributor
Author
|
Thanks @breenmachine ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudowithin the script, and rather added verbiage to the README and script to run it withsudo