8000 Support typescript indentation · Issue #96 · bradzacher/eslint-plugin-typescript · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Support typescript indentation #96

Closed
dwasyluk opened this issue Nov 23, 2017 · 4 comments
Closed

Support typescript indentation #96

dwasyluk opened this issue Nov 23, 2017 · 4 comments
Labels
new rule/new functionality

Comments

@dwasyluk
Copy link

It doesnt seem like tslint indent is supported, which exposes things like interfaces to inconsistent spacing.
@weirdpattern
Copy link
Collaborator

Hi @dwasyluk, thanks for submitting this issue. Could you please provide an example?
Any kind of documentation will also be very helpful (maybe a link to TSLint?)

@macklinu
Copy link
Collaborator

TSLint's indent documentation and link to source code

@macklinu macklinu mentioned this issue Apr 29, 2018
Closed
@bradzacher bradzacher added new rule/new functionality requires investigation bug that require more investigation labels Nov 16, 2018
@armano2
Copy link
Contributor
armano2 commented Dec 14, 2018

#219

@bradzacher bradzacher removed the requires investigation bug that require more investigation label Dec 15, 2018
@bradzacher bradzacher mentioned this issue Dec 15, 2018
Merged
@bradzacher
Copy link
Owner

closing this in favor of #201

bradzacher added a commit that referenced this issue Dec 17, 2018
@bradzacher
[FEAT] [indent] Extend the base rule to support TS nodes (#219)
84808c1 
Fixes #201 
Fixes #96 
Fixes eslint/typescript-eslint-parser#577

The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes).

Because of how the base rule is written, we have to override the implementation entirely.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
new rule/new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@armano2 @dwasyluk @macklinu @bradzacher @weirdpattern
0