Backport PR bqplot#1644: fix: save_png doesn't work when character \xa0 is used (#1644) #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27bff04 to
0461ef6
Compare
Member
Author
|
@martinRenou ouch, looks like some CI rot, did you see this one before? Seems like #1627 is the first that failed |
Member
Maybe karma-webpack would need to be pinned, or we can try to update nodejs... |
0461ef6 to
20627e4
Compare
20627e4 to
d360e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The character \xa0 is converted to when .outerHTML() is called, causing an error in the data-URL where the outer HTML is used.
(cherry picked from commit 4d5c293)
References
Code changes
User-facing changes
Backwards-incompatible changes