8000 fix(BTableSimple): implement 'fixed' and 'noBorderCollapse' props by tbl0605 · Pull Request #2688 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]
Skip to content

fix(BTableSimple): implement 'fixed' and 'noBorderCollapse' props #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

fix(BTableSimple): implement 'fixed' and 'noBorderCollapse' props #2688

merged 1 commit into from
May 11, 2025

Conversation

tbl0605
Copy link
Contributor
@tbl0605 tbl0605 commented May 9, 2025 •
edited by coderabbitai bot
Loading

Describe the PR

Correctly handle the 'fixed' and 'noBorderCollapse' props in BTableSimple components.

Fixes #2685.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Summary by CodeRabbit

  • New Features
    • Table now supports conditional styling for fixed layout and disabling border collapse based on new options.
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 9, 2025 •
edited
Loading

Walkthrough

The BTableSimple component was updated to conditionally apply the CSS classes 'b-table-fixed' and 'b-table-no-border-collapse' based on the fixed and noBorderCollapse props, respectively. This enhances the computedClasses logic, ensuring these classes are present when the related props are set.

Changes

File(s) Change Summary
packages/bootstrap-vue-next/src/components/BTable/BTableSimple.vue Added conditional class bindings for 'b-table-fixed' and 'b-table-no-border-collapse' to the computedClasses property.

Sequence Diagram(s)

sequenceDiagram
    participant ParentComponent
    participant BTableSimple

    ParentComponent->>BTableSimple: Render with props (fixed, noBorderCollapse, table-class)
    BTableSimple->>BTableSimple: Compute classes (including b-table-fixed, b-table-no-border-collapse)
    BTableSimple-->>ParentComponent: Rendered table element with appropriate classes
Loading

Assessment against linked issues

Objective Addressed Explanation
Ensure 'fixed' and 'noBorderCollapse' props apply correct classes even with 'table-class' (#2685) ✅

Possibly related PRs

Suggested reviewers

  • VividLemon

Poem

A table set with care anew,
With classes fixed and borders too,
Props align, the styles appear,
No more bugs for us to fear!
🐰✨

Hop, hop, hooray—
The table’s dressed the proper way!

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 9, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/bootstrap-vue-next/src/components/BTable/BTableSimple.vue (1)

76-77: Ensure CSS definitions exist and add tests for new props
The conditional class bindings for 'b-table-fixed' and 'b-table-no-border-collapse' look correct, but please verify that these classes are defined in your SCSS/CSS so the styling is actually applied. Also consider adding unit or snapshot tests (e.g. in BTableSimple.spec.ts) to assert that these classes appear when fixed or noBorderCollapse are truthy.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce869f0 and 4de8d06.

📒 Files selected for processing (1)
  • packages/bootstrap-vue-next/src/components/BTable/BTableSimple.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented May 9, 2025

bsvn-vite-ts

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2688

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2688

commit: 4de8d06

@VividLemon VividLemon merged commit c61f532 into bootstrap-vue-next:main May 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@VividLemon VividLemon VividLemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'fixed' and 'noBorderCollapse' props do not work with 'table-class' prop
2 participants
@tbl0605 @VividLemon
0