-
-
Notifications
You must be signed in to change notification settings - Fork 151
fix(BTableSimple): implement 'fixed' and 'noBorderCollapse' props #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe BTableSimple component was updated to conditionally apply the CSS classes 'b-table-fixed' and 'b-table-no-border-collapse' based on the Changes
Sequence Diagram(s)sequenceDiagram
participant ParentComponent
participant BTableSimple
ParentComponent->>BTableSimple: Render with props (fixed, noBorderCollapse, table-class)
BTableSimple->>BTableSimple: Compute classes (including b-table-fixed, b-table-no-border-collapse)
BTableSimple-->>ParentComponent: Rendered table element with appropriate classes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/bootstrap-vue-next/src/components/BTable/BTableSimple.vue (1)
76-77
: Ensure CSS definitions exist and add tests for new props
The conditional class bindings for'b-table-fixed'
and'b-table-no-border-collapse'
look correct, but please verify that these classes are defined in your SCSS/CSS so the styling is actually applied. Also consider adding unit or snapshot tests (e.g. inBTableSimple.spec.ts
) to assert that these classes appear whenfixed
ornoBorderCollapse
are truthy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/bootstrap-vue-next/src/components/BTable/BTableSimple.vue
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
commit: |
Describe the PR
Correctly handle the 'fixed' and 'noBorderCollapse' props in BTableSimple components.
Fixes #2685.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
feat(...)
fix(...)
docs(...)
The PR fulfills these requirements:
CHANGELOG
is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be deniedSummary by CodeRabbit