feat(BTableLite): add table-colgroup slot
#2680
Conversation
|
|
WalkthroughThis update introduces support for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BTable
participant BTableLite
User->>BTable: Provide table-colgroup slot
BTable->>BTableLite: Pass table-colgroup slot
BTableLite->>BTableLite: Render <colgroup> with slot content (if provided)
BTableLite->>User: Display table with custom column groups
Assessment against linked issues
Suggested reviewers
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (7)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
packages/bootstrap-vue-next/src/components/BTable/BTableLite.vue
Outdated
Show resolved
Hide resolved
| @@ -344,6 +347,8 @@ type SortSlotScope = { | |||
|
|
|||
| const slots = defineSlots<{ | |||
| // BTableLite | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| 'table-colgroup'?: (props: {columns: number; fields: typeof computedFields.value}) => any | |||
There was a problem hiding this comment.
Remove the fields scope, add it to the migration guide as a breaking change
|
@xvaara Will you be able to help review this PR, please? |
|
I think I got it mixed up. We want whatever scope is the array of objects. The '.length's property is redundant. Then add in the migration guide that the scope was removed |
|
Updated. However, this slot is the odd one now. Most other slots in TableLite provide both
|
|
Are they all just aliases of the .length property? |
|
Yes |
|
Remove them all. Add it to the migration guide |
|
I can put up a separate PR for that. I don't think those changes belong here. |
* upstream/main: chore: remove blur from boverlay in cases where its not allowed by br… (bootstrap-vue-next#2712) feat(BTableLite): add `table-colgroup` slot (bootstrap-vue-next#2680) perf: use getter functions over computed in some cases feat(BModal): use css var for zindex, add helper vars and ontop class (bootstrap-vue-next#2556) feat(BFormTags): added feedbackAriaLive prop (bootstrap-vue-next#2696) fix(scss) moved all scss styles out of components (bootstrap-vue-next#2671) fix(BModal): ensure clicking inside and releasing outside does not close modal (bootstrap-vue-next#2703) (bootstrap-vue-next#2704) fix(BToast): race condition if using setInterval to update countdown doc data feat(BPopover): add titleClass and bodyClass, remove unneeded customClass prop since class is inherited to the same place feat(BToast): add noProgress prop, make progress show as default if modelValue is number. fix(useToastController): if using the deprecated show method the countdown didn't start.
Describe the PR
Add table-colgroup slot to BTableLite component for custom column width definitions.
Fixes #2520.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
Summary by CodeRabbit
Summary by CodeRabbit
New Features
table-colgroup, in tables, allowing users to specify custom column widths.table-colgroupslot for column width customization.Documentation
table-colgroupslot and provide a usage example.