docs: migration guide for changes to show/hide related props #2386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
commit: |
VividLemon
approved these changes
Nov 26, 2024
|
I'm quite sure there are some mistakes there. The whole pr got out of hands and I didn't have the time or the energy to go through everything in it.
On BAccordianItem it passes down the attrs to BCollapse. So they aren't defined as props, but work. Create an issue to keep track.
I'll create a pull request for these. Check out if I missed anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This is an attempt to encapsulate the prop changes in #1821. I will also get to the emit changes, but they were more straightforward so I'll tack them separately.
@xvaara In the process of gong through the code for #1821 I found a number of things that I either don't understand or are internally inconsistent (as well as the bug I filed yesterday #2385)
I'm going to list them here for now, but happy to pull them out as a bug or bugs if you agree they are issues:
faderather thannoFade- for carousel, this makes a lot of sense since this is referring to the transition within the component that defaults toslide, but for BAlert it seems like it might be better to have it follow the semantics of the other show/hide components. Certainly if we ever want the option to implement RFC: Unify BToast and BAlert (and maybe useShowHide Alert) #2366, we'd want to line up the semantics now.toggle-preventedevent is missing onBCollapse,BNavItemDropdown*-preventedshould have value arg of BvTriggerableEventBOffCanvas,BPopover, andBToastdon't declare eventstoggleortoggle-prevented, but they exposetoggle, so I think they will emit those events?Small replication
N/A
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied