8000 docs: Use Not Yet Implemented Component consistently by dwgray · Pull Request #2183 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]

Skip to content

docs: Use Not Yet Implemented Component consistently #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

dwgray
Copy link
Member
@dwgray dwgray commented Sep 11, 2024

Describe the PR

  • Small tweak to the NYI component to make it a little less red
  • Used NYI in all of the *.md files that previously had free-text notes
  • Added an notYetImplemented flag to props and scoped slot args

Small replication

N/A

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
pkg-pr-new bot commented Sep 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2183
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2183

commit: a36e511

@dwgray dwgray marked this pull request as ready for review September 11, 2024 01:32
@VividLemon VividLemon merged commit a44d2b9 into bootstrap-vue-next:main Sep 11, 2024
4 checks passed
@dwgray dwgray deleted the not-yet-implemented branch September 11, 2024 17:01
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Sep 11, 2024
* upstream/main: (179 commits)
  chore: release main (bootstrap-vue-next#2175)
  docs(BImg): Parity pass (bootstrap-vue-next#2177)
  docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183)
  docs(BCarousel): Parity pass (bootstrap-vue-next#2179)
  feat(BCarousel): add click:prev and click:next events
  refactor: reduce module packages complexity
  refactor: make define models use component imported prop type
  fix directives on element update during interaction (bootstrap-vue-next#2170)
  fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169)
  chore: release main (bootstrap-vue-next#2172)
  fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171)
  Update vite template for bugs to work now that it seems we don't import components
  docs(BCard): Parity pass (bootstrap-vue-next#2168)
  docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152)
  Delete .github/workflows/pkg-pr-new.yaml
  Update ci.yaml with pkg.pr.new
  add pkg.pr.new to publish a package for each commit and pull request
  chore: release main (bootstrap-vue-next#2149)
  fix(BPagination): Get rid of bad binding on li (bootstrap-vue-next#2150)
  fix: pass attributes through in BDropdownItemButton (bootstrap-vue-next#2143)
  ...
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Sep 11, 2024
* upstream/main:
  chore: release main (bootstrap-vue-next#2175)
  docs(BImg): Parity pass (bootstrap-vue-next#2177)
  docs: Use Not Yet Implemented Component consistently (bootstrap-vue-next#2183)
  docs(BCarousel): Parity pass (bootstrap-vue-next#2179)
  feat(BCarousel): add click:prev and click:next events
  refactor: reduce module packages complexity
  refactor: make define models use component imported prop type
  fix directives on element update during interaction (bootstrap-vue-next#2170)
  fix(BTabs): fix recursion on titleLinkAttrs (bootstrap-vue-next#2169)
  chore: release main (bootstrap-vue-next#2172)
  fix(BPagination): hide-goto-end doesn't hide firstPage or lastPage (bootstrap-vue-next#2171)
  Update vite template for bugs to work now that it seems we don't import components
  docs(BCard): Parity pass (bootstrap-vue-next#2168)
  docs(BPagination): Update Component refs & clean up documentation (bootstrap-vue-next#2152)
  Delete .github/workflows/pkg-pr-new.yaml
  Update ci.yaml with pkg.pr.new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0