8000 clear up Popover target & reference props by xvaara · Pull Request #1460 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]
Skip to content

clear up Popover target & reference props #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2023
Merged

clear up Popover target & reference props #1460

merged 1 commit into from
Sep 16, 2023

Conversation

xvaara
Copy link
Contributor
@xvaara xvaara commented Sep 16, 2023

closes #1455

fix(BPopover): remove function from BPopover target and Reference props and add MaybeRef to it.

I couldn't think why I added function there, and only one using it was the directives (which don't need to use it)

@xvaara xvaara requested a review from VividLemon September 16, 2023 05:43
@xvaara xvaara merged commit d6f971b into bootstrap-vue-next:main Sep 16, 2023
@xvaara xvaara deleted the popover-type-fix branch October 13, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VividLemon VividLemon Awaiting requested review from VividLemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue props type error for BPopover if using HTMLElement
1 participant
@xvaara
0