10000 fix(b-icon): correct incorrect SCSS variable by Hiws · Pull Request #6341 · bootstrap-vue/bootstrap-vue · GitHub
[go: up one dir, main page]
Skip to content

fix(b-icon): correct incorrect SCSS variable #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

fix(b-icon): correct incorrect SCSS variable #6341

merged 2 commits into from
Jan 21, 2021

Conversation

Hiws
Copy link
Member
@Hiws Hiws commented Jan 21, 2021 •
edited by jacobmllr95
Loading

Describe the PR

Looks like the throb duration variable had been used for the fade animation, instead of the fade duration variable.
This PR fixes that.

This could be a potentially breaking change, for users who have used the previous variable to adjust the fade animation.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and 8000 determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@Hiws Hiws requested a review from jacobmllr95 January 21, 2021 08:52
@vercel
Copy link
vercel bot commented Jan 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/jk7gbeud4
✅ Preview: https://bootstrap-vue-git-fork-hiws-b-icon-fix-fade-scss.bootstrap-vue.vercel.app

@codesandbox-ci
Copy link
codesandbox-ci bot commented Jan 21, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f8a09ba:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link
codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #6341 (f8a09ba) into dev (47ac08a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          299       299           
  Lines        10105     10105           
  Branches      2512      2512           
=========================================
  Hits         10105     10105
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ac08a...f8a09ba. Read the comment docs.

@jacobmllr95 jacobmllr95 changed the title fix(b-icon): Fix incorrect SCSS variable fix(b-icon): correct incorrect SCSS variable Jan 21, 2021
@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Fix Type: SCSS labels Jan 21, 2021
@jacobmllr95 jacobmllr95 merged commit c5f5636 into bootstrap-vue:dev Jan 21, 2021
@Hiws Hiws deleted the b-icon-fix-fade-SCSS branch March 25, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees
No one assigned
Labels
PR: Patch Requires patch version bump Type: Fix Type: SCSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hiws @jacobmllr95
0