Support new webpack features and internalize CSS functions. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10xjs
reviewed
Oct 20, 2017
README.md
Outdated
| }], | ||
| }, | ||
| }; | ||
| ``` | ||
|
|
||
| NOTE: You don't need to chain with [value-loader] per-se, but doing so gives you caching, nested dependency monitoring/reloading and the ability to use webpack's module rollup. |
There was a problem hiding this comment.
I haven't heard of webpack using "rollup" to describe this this feature. Stick with "tree shaking" or "unused module export detection" instead.
Support for `value-loader` has been added by checking to see if the source is an object instead of a string – this allows for a bunch of nice things (caching, support for `modules: false` in babel, nested dependency resolution, etc.) because `value-loader` spawns a child compiler that runs the full webpack process. We also update several packages here (lint, etc.) because why not. The internal react functions have been moved into the repo to remove the react dependency. This means you won't pull two versions of react into your project and get weird peer dependency warnings.
fc5ae47 to
399e3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
value-loaderhas been added by checking to see if the source is an object instead of a string – this allows for a bunch of nice things (caching, support formodules: falsein babel, nested dependency resolution, etc.) becausevalue-loaderspawns a child compiler that runs the full webpack process.We also update several packages here (lint, etc.) because why not.
The internal react functions have been moved into the repo to remove the react dependency. This means you won't pull two versions of react into your project and get weird peer dependency warnings.