Protect against document == null in _doc_detached()
#14430
Conversation
|
Seems high priority, can we backport to 3.7.1 and release relatively soon? |
|
We can definitely have a 3.7.1 ASAP. If theres any handful of other tiny fix that can go in ~immediately, then that would be nice, but if not there's no reason to hold this up. Let's shoot for Monday at the latest? If any sort of test is possible that would be nice to have in place before a more in-depth follow-up. |
|
The underlying problem was that updating a figure means |
94991d9 to
2f91161
Compare
There was a problem hiding this comment.
Left some comments. I'm unfamiliar with this code, so they may be a bit naive.
|
@mattpap what about putting the quick defensive "fix" in 3.7.1 and saving these more involved changes for 3.8? |
There was a problem hiding this comment.
I'll approve but I do think some quick manual testing of most/all the app examples is in order if that hasn't already been done. Also would good to know if this is the fix for https://discourse.bokeh.org/t/dynamically-create-tabs-with-figures-in-them/12368/2
That was my original goal. However, after spending time debugging the root cause, I can clearly see it's a mess what happens when a patch arrives that causes |
I didn't verify this, but it clearly looks like it's the same problem. |
* Protect against `document == null` in `_doc_detached()` * Make Document.all_models eventually consistent * Allow to configure model re-computation behavior * Update Document's unit tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
For now this work around the problem, but I will need to investigate why we detach a detached model in the first place.
fixes #14429